Use default protocol/port when destination is service in antrea traceflow #6601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Atish-iaf
added
kind/bug
Atish-iaf
changed the title
antoninbas
reviewed
Aug 8, 2024
antoninbas
reviewed
Aug 8, 2024
antoninbas
reviewed
Aug 19, 2024
If destination protocol/port isn't provided when destination is service in antrea traceflow, it just uses destinaton service's IP(clusterIP) and runs traceflow as Pod-to-IP(icmp) case which is incorrect. To fix this, we use the first protocol and port from the service's 'ports' list as default value. Fixes antrea-io#6594 Signed-off-by: Kumar Atish <[email protected]>
rajnkamr
reviewed
Aug 21, 2024
Comment on lines
+497
to
+501
| case corev1.ProtocolTCP: | ||
| packet.IPProto = protocol.Type_TCP | ||
| packet.TCPFlags = uint8(2) | ||
| case corev1.ProtocolUDP: | ||
| packet.IPProto = protocol.Type_UDP |
There was a problem hiding this comment.
The switch statement does not include a default case. While the current implementation handles TCP and UDP, if the service protocol is SCTP which is also currently not supported , we could add a default case !
default:
// Handle unsupported protocols, maybe log a warning
There was a problem hiding this comment.
defaults to ICMP which is consistent with other cases also.
In this case, the behaviour will be run traceflow as Pod-to-IP(Service's ClusterIP) with ICMP protocol.
antoninbas
approved these changes
Aug 23, 2024
|
/test-all |
antoninbas
added
the
action/release-note
rajnkamr
added
the
kind/documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If destination protocol/port isn't provided when destination is service in antrea traceflow, it just uses destinaton service's IP(clusterIP) and runs traceflow as Pod-to-IP(icmp) case which is incorrect.
To fix this, we use the first protocol/port from the service's 'ports' list as default value.
Fixes #6594